DM-22301: Improve printing of task configs #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivial fix to not add extra line breaks when filtering configuration field names with --show=config=... option. It still has a chance to produce incorrect output for some expressions, better fix will be added on a new ticket.
andy-slac
force-pushed
the
tickets/DM-22301
branch
from
18dc117
to
3d81fbf
Compare
TallJimbo
approved these changes
Jan 17, 2020
The `--show=config` option now prints configuration without imports. New option `--show=dump-config[=Task]` now dumps complete configuration for a task (or all tasks) with all imports.
With previous code it was not possible to specify configurable field for printing config history. Now one can use natural configuration syntax for those fields, exactly as it appears in config overrides, e.g. `--show history="measurePsf.psfDeterminer['pca'].lam"`.
andy-slac
force-pushed
the
tickets/DM-22301
branch
from
3d81fbf
to
c0db5c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--show=configoption now prints configuration without imports. Newoption
--show=dump-config[=Task]now dumps complete configuration fora task (or all tasks) with all imports.
Config history option was improved as well, one can use natural configuration
syntax for configurable fields, exactly as it appears in config overrides, e.g.
--show history="measurePsf.psfDeterminer['pca'].lam".