DM-25016: Fix reading of QuantumGraph from pickle file #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
force-pushed
the
tickets/DM-25016
branch
from
8e488d1
to
893b41c
Compare
timj
reviewed
May 22, 2020
| Registry configuration for initialized registry database. | ||
| """ | ||
| with makeTmpFile() as filename: | ||
| uri = f"sqlite:///{filename}" |
There was a problem hiding this comment.
Does this have to be a file? Can't it be an in-memory sqlite?
There was a problem hiding this comment.
In-memory does not work in this case, there is a discussion on JIRA about this issue. Basically if you want to open registry in read-only mode then you can't use in-memory because every session for in-memory sqlite makes it's own database which cannot be shared, and read-only database cannot be initialized with all the stuff that we need.
TallJimbo
approved these changes
May 24, 2020
When reading QuantumGraph from pickle DimensionUniverse instance must be initialized, this fix makes registry instance before un-pickling which creates all necessary instances. This trivial fix exposed an issue with my dumb unit test that also needed proper fix.
andy-slac
force-pushed
the
tickets/DM-25016
branch
from
893b41c
to
fa5dede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading QuantumGraph from pickle DimensionUniverse instance must be
initialized, this fix makes registry instance before un-pickling which
creates all necessary instances. This trivial fix exposed an issue with
my dumb unit test that also needed proper fix.