DM-25222: Fix handling of skip-existing in PreExecInit #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Jun 3, 2020
| objFromStore = self.butler.get(attribute.name, {}) | ||
| if objFromStore is not None: | ||
| try: | ||
| objFromStore = self.butler.get(attribute.name, {}) | ||
| # Types are supposed to be identical. |
There was a problem hiding this comment.
Datastore.get does check that the returned python object is an instance of the StorageClass python type. It does not require that types match directly. Your test here is more stringent than butler -- does it ever trigger?
There was a problem hiding this comment.
I have no idea, probably not because we did not see any questions/complaints about this. What we want to do is to make sure that objects are identical but there is no way to do it now for arbitrary types, checking that types are identical is the minimum that we can do here.
PreExecInit expected butler.get() to return None for missing datasets, while in reality it raises LookupError. Fixing this and also adding unit test for this.
andy-slac
force-pushed
the
tickets/DM-25222
branch
from
7d88737
to
02a830a
Compare
MichelleGower
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreExecInit expected butler.get() to return None for missing datasets,
while in reality it raises LookupError. Fixing this and also adding unit
test for this.