DM-26136: Improve handling of crashes in pipetask #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is implemented using multiprocesing Pool class, but I need to switch from Pool to lower-level Process because Pool does not support stopping long running (timed out) processes (and it is just broken).
timj
approved these changes
Aug 20, 2020
| # but multiprocessing does not provide an API for that, for now | ||
| # just sleep a little bit and go back to the loop. | ||
| if jobs.running(): | ||
| time.sleep(0.1) |
There was a problem hiding this comment.
I can't help pondering asyncio in cases like this where we are sleeping and looping.
There was a problem hiding this comment.
I'm not very proud of this two lines of code, it's stupid and inefficient. We could certainly do fancier things here, in the context of pipetask it probably does not matter very much, but generally I agree we want to make things behaving better. Maybe something for later ticket together with finally getting rid of multiprocessing stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced use of multiprocessing Pool with manual process management based on
Processclass. Crashes in sub-processes should be handled correctly now. Exceptions are not propagated to main process, they will appear in the log when subprocess fail, main process will just list all tasks that failed.Implemented "keep running" as default option, there is new command line option
--fail-fastwhich turns on old behavior.