DM-26726: Freeze Config prior to running the quantum #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
Sep 21, 2020
timj
commented
Sep 22, 2020
| @@ -246,8 +249,7 @@ def runQuantum(self, task, quantum, taskDef, butler): | |||
| butlerQC = ButlerQuantumContext(butler, quantum) | |||
|
|
|||
| # Get the input and output references for the task | |||
| connectionInstance = task.config.connections.ConnectionsClass(config=task.config) | |||
| inputRefs, outputRefs = connectionInstance.buildDatasetRefs(quantum) | |||
| inputRefs, outputRefs = taskDef.connections.buildDatasetRefs(quantum) | |||
There was a problem hiding this comment.
@andy-slac I'm not sure if this change is controversial? We have access to the TaskDef so in theory we don't need to recreate the connections object here. I assume the main worry is that by this point the TaskDef and Task can be out of sync somehow?
There was a problem hiding this comment.
I am not sure now where the original code comes from, but this change looks OK to me.
There was a problem hiding this comment.
I think I remember that existing prior to TaskDefs carrying around a connections instance, and think it never got cleaned up. This change looks fine.
timj
force-pushed
the
tickets/DM-26726
branch
from
fded031
to
937b783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.