DM-26739: Add task label to long log message #83
Conversation
| else: | ||
| Log.MDC("LABEL", '[' + ', '.join([str(dataId) for dataId in dataIds]) + ']') | ||
| Log.MDC("LABEL", f'{taskDef.label}:[' + ', '.join([str(dataId) for dataId in dataIds]) + ']') |
There was a problem hiding this comment.
Not a big deal, but why the space after the colon above but not here? Might make it messier to extract stuff automatically from the logs to have these inconsistent.
There was a problem hiding this comment.
It was a mistake. Fixed and removed the space in the first one.
There was a problem hiding this comment.
Although extraction of dataIds is going to need a tricky regex, especially if the dataId values include a ].
There was a problem hiding this comment.
This is where JSON logs can help... Still, the )( in the longlog format should be good enough.
There was a problem hiding this comment.
Before my SSD died last night and wiped the code out, I was going to see if I can serialize those dataIds into Json form in the log. I'll try it again.
timj
force-pushed
the
tickets/DM-26739
branch
2 times, most recently
from
8d88a29
to
f89167a
Compare
|
@andy-slac and @ktlim can you take another look please? I've switched to using JSON to serialize the dataId and removed the special case for single dataId. |
|
Well, I was actually suggesting having a mode where the entire log message (including timestamps, log level, etc.) is JSON so that no parsing/regexps are necessary. If the dataId isn't dict-like enough for JSON to serialize it without help, you might be better off with the original |
|
I'm not going to tackle full JSON-ification of logging here. Using the single quantum dataId simplifies the code a lot more so I'll do a final tweak and remove the json.dumps. |
No longer use all the input quanta in log label.
timj
force-pushed
the
tickets/DM-26739
branch
from
2557a1c
to
cf3af1f
Compare
No description provided.