DM-26483: Add wildcards to --show history for config name matching #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-26483
branch
2 times, most recently
from
8e6d2bd
to
1469eba
Compare
ktlim
approved these changes
Oct 7, 2020
|
|
||
| # Sometimes we end up with a non-Config so skip those | ||
| if isinstance(hconfig, pexConfig.Config) and hasattr(hconfig, cname): | ||
| print(f"### Configuration field for task `{taskDef.label}'") |
There was a problem hiding this comment.
I guess this matches the prior output, but it seems weird to have repeated identical section headers like this for a given task.
There was a problem hiding this comment.
I think I'm fine with it repeating the task name each time. Otherwise you have to scroll up to find out which task's config you are looking at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.