DM-27519: Improve printing of config history #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to find a better way to navigate Config structure but in the end decided that `eval` is the easiest and most natural way to do it. I did not want to parse the printed attribute representation myself (do not want to re-implement `eval`) and navigating Config class hierarchy needs too much effort.
ktlim
approved these changes
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to find a better way to navigate Config structure but in the end
decided that
evalis the easiest and most natural way to do it.I did not want to parse the printed attribute representation myself (do
not want to re-implement
eval) and navigating Config class hierarchyneeds too much effort.