DM-42530: changes to templates for START condition etc #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelleGower
changed the title
MichelleGower
approved these changes
Jan 30, 2024
| @@ -27,7 +27,7 @@ AUTO_INCLUDE_SHARED_PORT_IN_DAEMON_LIST=False | |||
| USE_SHARED_PORT=False | |||
|
|
|||
| # START = ( (Owner == "$USER_NAME") && (JOB_NODE_SET == "$NODE_SET" ) ) | |||
| START = (Owner == "$USER_NAME") | |||
| # START = (Owner == "$USER_NAME") | |||
There was a problem hiding this comment.
If not providing examples for something a user can set in a config, we probably should not have commented out code when branch is ready to merge.
There was a problem hiding this comment.
Yes the comment lingering there is kind of cryptic reminder that "we used to set this here, but now it is set elsewhere, in env vars" (in case someone would actually look for the START expression).
So yes it can be removed, or maybe the comment statement can actually just say that the START condition is not set in the config but in scripted Env vars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.