Merge pull request #76 from lsst/tickets/DM-37080

DM-37080: Raise if toPython is called on invalid DateTime.
lsst · Nov 24, 2022 · 4fd1a49 · 4fd1a49
2 parents 5c4744a + eec769b
commit 4fd1a49
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/python/lsst/daf/base/dateTime/dateTimeContinued.py b/python/lsst/daf/base/dateTime/dateTimeContinued.py
@@ -44,8 +44,15 @@ def toPython(self, timescale=None):
         -------
         datetime : `datetime.datetime`
             The resultant Python `datetime.datetime` object.
+
+        Raises
+        ------
+        ValueError
+            Raised if the DateTime is invalid (uninitialized).
         """
         import datetime
+        if not self.isValid():
+            raise RuntimeError("DateTime not valid")
         nsecs = self.nsecs(timescale) if timescale is not None else self.nsecs()
         return datetime.datetime.utcfromtimestamp(nsecs/10**9)
 

diff --git a/tests/test_dateTime.py b/tests/test_dateTime.py
@@ -333,6 +333,8 @@ def testInvalid(self):
                 ts.timeval(scale)
             with self.assertRaises(RuntimeError):
                 ts.toString(scale)
+            with self.assertRaises(RuntimeError):
+                ts.toPython()
         self.assertEqual(repr(ts), "DateTime()")
 
     def testNegative(self):