DM-10328: len(propertySet) throws an exception in Python #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strip trailing whitespace Add newlines where wanted Add a few `# noqa` to stop warnings where the code must violate PEP8 Stop using `from foo import *` in code
n8pease
reviewed
Apr 24, 2017
| @@ -23,7 +23,7 @@ | |||
| # see <http://www.lsstcorp.org/LegalNotices/>. | |||
| # | |||
|
|
|||
| from __future__ import division | |||
| from __future__ import absolute_import, division, print_function | |||
There was a problem hiding this comment.
the commit message and the change don't seem to line up.
r-owen
force-pushed
the
tickets/DM-10328
branch
from
3216b73
to
13fa11a
Compare
including adding it in a few cases where it was missing.
Not only it broken, it is not obvious what it should return. Add an explanation of this as a code comment in the pybind11 wrapper.
r-owen
force-pushed
the
tickets/DM-10328
branch
from
a900c6e
to
50efa46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.