Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-11661: Enable flake8 testing #29

Merged
merged 3 commits into from
Aug 28, 2017
Merged

DM-11661: Enable flake8 testing #29

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f6c475
Fix a deprecation warning
timj Aug 26, 2017
cbc3c0a
Ignore pytest cache file
timj Aug 26, 2017
d2ecd0d
Enable auto test discovery with pytest and flake8
timj Aug 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[flake8]
max-line-length = 110
ignore = E133, E226, E228, N802, N803, N806
exclude = __init__.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config differs a bit from the one in the style guide -- in particular, the N806 ignore is new.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for science pipelines: https://developer.lsst.io/coding/python_style_guide.html#exceptions-to-pep-8

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E251 should in theory be included but in this case it never triggers anything so I left it out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine. Maybe there's a clearer way to organize the rules...


[tool:pytest]
addopts = --flake8
flake8-ignore = E133 E226 E228 N802 N803 N806
2 changes: 1 addition & 1 deletion tests/SConscript
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# -*- python -*-
from lsst.sconsUtils import scripts
scripts.BasicSConscript.tests()
scripts.BasicSConscript.tests(pyList=[])