DM-13084: Be smarter about combining metadata from FITS headers #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and the same test for PropertyList.copy
r-owen
force-pushed
the
tickets/DM-13084
branch
from
9d292a1
to
6fd1bf0
Compare
r-owen
commented
Jan 16, 2018
| auto vp = std::make_shared<vector<boost::any>>(*(sj->second)); | ||
| _set(dest, vp); | ||
| } | ||
| } |
There was a problem hiding this comment.
There is a small bit of code duplication here: _set(det, vp). I thought about eliminating it by initializing vp to a blank vector outside of the if/else, appending to it in the asScalar branch and replacing it in the else branch. I felt the current code might be a bit easier to read, but will gladly change it on request.
ktlim
approved these changes
Jan 18, 2018
include/lsst/daf/base/PropertyList.h
Outdated
| virtual ~PropertyList(void); | ||
|
|
||
| // Accessors | ||
| /** | ||
| * Make a deep copy the PropertyList and all of its contents. |
include/lsst/daf/base/PropertySet.h
Outdated
| // Accessors | ||
|
|
||
| /** | ||
| * Make a deep copy the PropertySet and all of its contents. |
include/lsst/daf/base/PropertySet.h
Outdated
| virtual void combine(ConstPtr source); | ||
| // All vectors from the source are add()ed to the destination with the | ||
| // same names. Types must match. |
There was a problem hiding this comment.
Should this ("types must match") move up to the doxygen comment instead of being removed? Or is the @throws TypeError sufficient?
There was a problem hiding this comment.
I'll add a note to the doc.
include/lsst/daf/base/PropertySet.h
Outdated
| AnyMap::iterator _find(std::string const& name); | ||
|
|
||
| /* Find2 the property name (possibly hierarchical). Const version. |
| auto vp = std::make_shared<vector<boost::any>>(*(sj->second)); | ||
| _set(dest, vp); | ||
| } | ||
| } |
And remove @file directives, which we now prefer not to have
and PropertyList::copy.
r-owen
force-pushed
the
tickets/DM-13084
branch
from
6fd1bf0
to
c2aa5ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.