Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-18488: Support pyyaml 5.1 #47

Merged
merged 3 commits into from Mar 21, 2019
Merged

DM-18488: Support pyyaml 5.1 #47

merged 3 commits into from Mar 21, 2019

Conversation

timj
Copy link
Member

@timj timj commented Mar 14, 2019

No description provided.

@timj
Also trap RuntimeError when querying type
ced480f 
Sometimes RuntimeError appears during my tests, rather than
NotFoundError.
@timj timj requested a review from ktlim March 14, 2019 22:18
@timj timj force-pushed the tickets/DM-18488-daf_base branch from d9a3c32 to 2616f29 Compare March 16, 2019 16:55
ktlim
ktlim approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@ktlim ktlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like in daf_persistence, consider using loaderList instead of Loaders.

@timj
Update the yaml constructor registration
8990c29 
In v5.1 pyyaml requires that we register the constructor
with FullLoader.
@timj
pyyaml 5.1 now requires an explicit Loader
1c03cf2 
Use FullLoader in preference to Loader.
@timj timj force-pushed the tickets/DM-18488-daf_base branch from 2616f29 to 1c03cf2 Compare March 21, 2019 21:26
@timj timj merged commit aef33af into master Mar 21, 2019
@timj timj deleted the tickets/DM-18488-daf_base branch March 21, 2019 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktlim ktlim ktlim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @ktlim