DM-9873: Add nullptr_t to PropertySet/PropertyList #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, pex exceptions raised inside the C++ layer do not reliably get converted to the correct Python exception type.
timj
force-pushed
the
tickets/DM-9873
branch
2 times, most recently
from
8c94377
to
3e0eaa2
Compare
This does seems to work, which would help more people use safe_load.
This should be undetectable to callers but should now benefit from the guaranteed order for Python dict insertion as of Python 3.6 and benefit from the dict speed ups in recent Python versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
Noneto be assigned to an entry in a PropertySet.