Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-21357: Add value and items methods to PropertySet/List #54

Merged
merged 1 commit into from Sep 19, 2019
Merged

DM-21357: Add value and items methods to PropertySet/List #54

merged 1 commit into from Sep 19, 2019

Conversation

timj
Copy link
Member

@timj timj commented Sep 18, 2019

They were missed by mistake previously since they do not
automatically get implemented because pybind11 classes
can't inherit from collections.abc

@timj
Add value and items methods to PropertySet/List
7997bf5 
They were missed by mistake previously since they do not
automatically get implemented because pybind11 classes
can't inherit from collections.abc
@timj timj requested a review from TallJimbo September 18, 2019 21:31
TallJimbo
TallJimbo approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was about to suggest we add a few more MutableMapping methods like setdefault, get, pop ... but given that some of those are probably impossible because they're already defined with different behavior, maybe it's best to just stop here.

@timj timj merged commit f033a76 into master Sep 19, 2019
@timj timj deleted the tickets/DM-21357 branch September 19, 2019 04:02
@timj
Copy link
Member Author

timj commented Sep 19, 2019

get is already implemented and is an alias for getScalar but with the defaulting behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @TallJimbo