Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-10339: Add valueCount() to get total number of entries. #63

Merged
merged 2 commits into from Nov 10, 2020
Merged

DM-10339: Add valueCount() to get total number of entries. #63

merged 2 commits into from Nov 10, 2020

Conversation

ktlim
Copy link
Contributor

@ktlim ktlim commented Nov 10, 2020

No description provided.

r-owen
r-owen approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you for adding this feature.

One request: please clarify the documentation for the new method to explain how vectors are handled.

include/lsst/daf/base/PropertySet.h Outdated Show resolved Hide resolved
@ktlim ktlim merged commit f910f65 into master Nov 10, 2020
@ktlim ktlim deleted the tickets/DM-10339 branch November 10, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-owen r-owen r-owen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ktlim @r-owen