DM-30339: replace boost::any with std::any #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwittgen
force-pushed
the
tickets/DM-30339
branch
from
89498c5
to
852b567
Compare
kfindeisen
approved these changes
Jun 10, 2021
src/PropertySet.cc
Outdated
| return boost::any_cast<T>(i->second->back()); | ||
| } catch (boost::bad_any_cast) { | ||
| return std::any_cast<T>(i->second->back()); | ||
| } catch (std::bad_any_cast &) { | ||
| throw LSST_EXCEPT(pex::exceptions::TypeError, name); |
There was a problem hiding this comment.
Not related to the migration, but it might be worth adding exception chaining, to keep information about the badly cast value from being lost:
Suggested change
| throw LSST_EXCEPT(pex::exceptions::TypeError, name); | |
| std::throw_with_nested(LSST_EXCEPT(pex::exceptions::TypeError, name)); |
Same with other cases below.
| return boost::any_cast<T>(i->second->back()); | ||
| } catch (boost::bad_any_cast) { | ||
| return std::any_cast<T>(i->second->back()); | ||
| } catch (std::bad_any_cast &) { |
There was a problem hiding this comment.
Suggested change
| } catch (std::bad_any_cast &) { | |
| } catch (std::bad_any_cast const&) { |
Same with other cases below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.