DM-32682: Allow del and pop to delete hierarchical names #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People use keys of "a.b.c" in remove() and we should allow that to work with del and pop. This requires we use exists() rather than "in" to check whether the key is present or not because "in" only looks at the top level since it has to be consistent with __iter__.
timj
force-pushed
the
tickets/DM-32682
branch
from
65cb7c9
to
56c0f04
Compare
ktlim
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People use keys of "a.b.c" in
remove()and we should allow that to work withdelandpop(). This requires we useexists()rather thaninto check whether the key is present or not becauseinonly looks at the top level since it has to be consistent with__iter__.