DM-33478: Try to speed up PropertySet on macOS ARM #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timj
commented
Feb 1, 2022
•
timj
commented
- Cache the type to name mapping. This mapping does not change and can be calculated once.
- Use exists rather than triggering a double try/except catch in guessIntegerType.
This mapping does not change and can be calculated once.
People do except that if they have a PropertySet with a NaN in it and compare it to another PropertySet that has a NaN in the same place in the hierarchy, that they should equate.
For some reason on M1 Pro/Max the (double) try/except is orders of magnitude slower than first checking for existence.
timj
force-pushed
the
tickets/DM-33478
branch
from
ef7586d
to
a912881
Compare
|
Ha, need to update the Python version... |
timj
changed the title
erykoff
approved these changes
Feb 2, 2022
| type_obj = getattr(PropertySet, "TYPE_" + checkType) | ||
| _TYPE_MAP[type_obj] = checkType | ||
| # Store both directions. | ||
| _TYPE_MAP[checkType] = type_obj |
There was a problem hiding this comment.
Just want to make sure that type_obj and checkType can never step on each other, right?
There was a problem hiding this comment.
Mypy would have a fit but one of them is a TypeInfo object and the other is a string so they can't stomp on each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.