DM-7028: Port to Python 3 #8
Conversation
| # the GNU General Public License along with this program. If not, | ||
| # | ||
| # You should have received a copy of the LSST License Statement and | ||
| # the GNU General Public License along with this program. If not, |
There was a problem hiding this comment.
Commit also includes PEP8 cleanup.
There was a problem hiding this comment.
I hoped you were going to let me get away with that one. My editor always strips spaces and I didn't catch this whitespace cleanup.
There was a problem hiding this comment.
I think RHL chastised me about that kind of editor setting several years ago.
* print function * absolute import
timj
force-pushed
the
tickets/DM-7028
branch
6 times, most recently
from
d3b2a2e
to
6e31c46
Compare
This can work in both python2 and python3+futurize.
timj
force-pushed
the
tickets/DM-7028
branch
4 times, most recently
from
2357f63
to
ed7f34c
Compare
|
|
||
| On Python 3 all ints are LongLong but we need to be able to store them | ||
| in Int containers if that is what is being used (testing for truncation). | ||
| Int is assumed to mean 32bit integer (2147483647 to -2147483648). |
There was a problem hiding this comment.
It may well be on most systems these days, but are we going to get bitten by assuming an architecture? Does PropertySet define it as a particular size, or just int ("at least 16 bits").
There was a problem hiding this comment.
It seems to be int. @ktlim could we actually define this to use int32_t to make it more explicit?
| minInt = -2147483648 | ||
|
|
||
| # We do not want to convert bool to int so let the system work that | ||
| # out itself |
There was a problem hiding this comment.
How annoying that isinstance(True, numbers.Integral) is True!
There was a problem hiding this comment.
My thoughts exactly when I saw the tests fail in afw last night.
There was a problem hiding this comment.
You had to wait for afw to fail before you knew there was a problem here? Can you add a test that will catch the problem in this package?
There was a problem hiding this comment.
I had to wait until obs_sdss for the integer overflow error to appear...
Python 3 does not distinguish long from int but PropertySet and PropertyList can have different types. If something is added to a container that already contains ints then assume Int, if it already contains LongLong use LongLong. If the container is empty choose based on the value. We are careful not to include bool types in the guess work. Adds some tests to ensure that boolean are handled properly and that OverflowError is raised if the item is too large.
SWIG now returns int instead of long when the return value can fit in an int.
No description provided.