DM-34195: Remove deprecated shared_ptr interfaces #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Jul 12, 2023
| [[deprecated("Replaced by a non-shared_ptr overload. Will be removed after v25.")]] | ||
| virtual void copy(std::string const& dest, std::shared_ptr<PropertySet const> source, | ||
| std::string const& name, bool asScalar = false); | ||
| //@} |
There was a problem hiding this comment.
Need to remove the opening //@{, too.
| [[deprecated("Replaced by a non-shared_ptr overload. Will be removed after v25.")]] | ||
| virtual void copy(std::string const& dest, std::shared_ptr<PropertySet const> source, | ||
| std::string const& name, bool asScalar = false); | ||
| //@} |
There was a problem hiding this comment.
Need to remove the opening //@{, too.
mwittgen
force-pushed
the
tickets/DM-34195
branch
from
d960eaf
to
db173ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.