Skip to content

Commit

Permalink
Re-enable butler test lost due to missing function definition.
Browse files Browse the repository at this point in the history
...and fix a pretty obvious bug in it.

Looks like a bad conflict resolution, but that wouldn't explain the bug.

In any case, I'm quite surprised flake8 wasn't mad about the
unqualified return statement in the middle of a function.
  • Loading branch information
TallJimbo committed Mar 4, 2020
1 parent 8815607 commit 2cfca3f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tests/test_butler.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@ def runPutGetTest(self, storageClass, datasetTypeName):

return butler

def testDeferredCollectionPassing(self):
# Construct a butler with no run or collection, but make it writeable.
butler = Butler(self.tmpConfigFile, writeable=True)
# Create and register a DatasetType
Expand Down Expand Up @@ -331,7 +332,7 @@ def runPutGetTest(self, storageClass, datasetTypeName):
# Deleting the dataset from the new collection should make it findable
# in the original collection.
butler.prune([ref], collection="tagged")
self.assertFalse(butler.datasetExists(datasetType, dataId, collection=run))
self.assertTrue(butler.datasetExists(datasetType, dataId, collection=run))


class ButlerTests(ButlerPutGetTests):
Expand Down

0 comments on commit 2cfca3f

Please sign in to comment.