Skip to content

Commit

Permalink
Switch back to lifting Location and FileDescriptor to package scope.
Browse files Browse the repository at this point in the history
These are part of the Formatter API, and as much as we'd like it to be
that's not just a FileDatastore implementation detail right now.
  • Loading branch information
TallJimbo committed Oct 6, 2023
1 parent f4470ee commit 63bc1b8
Show file tree
Hide file tree
Showing 9 changed files with 14 additions and 11 deletions.
2 changes: 2 additions & 0 deletions python/lsst/daf/butler/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@
from ._deferredDatasetHandle import *
from ._exceptions import *
from ._file_dataset import *
from ._file_descriptor import *
from ._formatter import *

# Do not import 'instrument' or 'json' at all by default.
from ._limited_butler import *
from ._location import *
from ._named import *
from ._quantum import *
from ._quantum_backed import *
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
from typing import TYPE_CHECKING, Any

if TYPE_CHECKING:
from .._storage_class import StorageClass
from .location import Location
from ._location import Location
from ._storage_class import StorageClass


class FileDescriptor:
Expand Down
4 changes: 2 additions & 2 deletions python/lsst/daf/butler/_formatter.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@
from ._config_support import LookupKey, processLookupConfigs
from ._dataset_ref import DatasetRef
from ._dataset_type import DatasetType
from ._file_descriptor import FileDescriptor
from ._location import Location
from ._storage_class import StorageClass
from .datastore.file_descriptor import FileDescriptor
from .datastore.location import Location
from .dimensions import DimensionUniverse
from .mapping_factory import MappingFactory

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion python/lsst/daf/butler/datastore/stored_file_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
from lsst.resources import ResourcePath

from .._formatter import Formatter, FormatterParameter
from .._location import Location, LocationFactory
from .._storage_class import StorageClass, StorageClassFactory
from .location import Location, LocationFactory

if TYPE_CHECKING:
from .. import DatasetId, DatasetRef
Expand Down
5 changes: 3 additions & 2 deletions python/lsst/daf/butler/datastores/fileDatastore.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,11 @@
DatasetTypeNotSupportedError,
Datastore,
FileDataset,
FileDescriptor,
Formatter,
FormatterFactory,
Location,
LocationFactory,
Progress,
StorageClass,
ddl,
Expand All @@ -60,9 +63,7 @@
DatastoreDisabledCacheManager,
)
from lsst.daf.butler.datastore.composites import CompositesMap
from lsst.daf.butler.datastore.file_descriptor import FileDescriptor
from lsst.daf.butler.datastore.file_templates import FileTemplates, FileTemplateValidationError
from lsst.daf.butler.datastore.location import Location, LocationFactory
from lsst.daf.butler.datastore.record_data import DatastoreRecordData
from lsst.daf.butler.datastore.stored_file_info import StoredDatastoreItemInfo, StoredFileInfo
from lsst.daf.butler.registry.interfaces import (
Expand Down
2 changes: 1 addition & 1 deletion python/lsst/daf/butler/tests/testFormatters.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
from ..formatters.yaml import YamlFormatter

if TYPE_CHECKING:
from ..datastore.location import Location
from .._location import Location


class DoNothingFormatter(Formatter):
Expand Down
4 changes: 2 additions & 2 deletions tests/test_formatter.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@
DatasetType,
DimensionGraph,
DimensionUniverse,
FileDescriptor,
Formatter,
FormatterFactory,
Location,
StorageClass,
)
from lsst.daf.butler.datastore.file_descriptor import FileDescriptor
from lsst.daf.butler.datastore.location import Location
from lsst.daf.butler.tests import DatasetTestHelper
from lsst.daf.butler.tests.testFormatters import (
DoNothingFormatter,
Expand Down
2 changes: 1 addition & 1 deletion tests/test_location.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
import posixpath
import unittest

from lsst.daf.butler.datastore.location import Location, LocationFactory
from lsst.daf.butler import Location, LocationFactory
from lsst.resources import ResourcePath


Expand Down

0 comments on commit 63bc1b8

Please sign in to comment.