Add remote registry getDatasetLocations

lsst · Jan 20, 2023 · 98b18dd · 98b18dd
1 parent 9359e02
commit 98b18dd
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/python/lsst/daf/butler/registries/remote.py b/python/lsst/daf/butler/registries/remote.py
@@ -412,7 +412,10 @@ def getDatastoreBridgeManager(self) -> DatastoreRegistryBridgeManager:
 
     def getDatasetLocations(self, ref: DatasetRef) -> Iterable[str]:
         # Docstring inherited from lsst.daf.butler.registry.Registry
-        raise NotImplementedError()
+        path = f"v1/registry/datasetLocations/{ref.id}"
+        response = self._client.get(self._get_url(path))
+        response.raise_for_status()
+        return response.json()
 
     def expandDataId(
         self,

diff --git a/tests/test_server.py b/tests/test_server.py
@@ -21,6 +21,7 @@
 
 import os.path
 import unittest
+import uuid
 
 try:
     import lsst.daf.butler.server
@@ -31,7 +32,7 @@
     from fastapi.testclient import TestClient
 except ImportError:
     TestClient = None
-from lsst.daf.butler import Butler, Config, DataCoordinate
+from lsst.daf.butler import Butler, Config, DataCoordinate, DatasetRef
 
 try:
     from lsst.daf.butler.server import app
@@ -111,6 +112,18 @@ def test_registry(self):
         ref = self.butler.registry.getDataset(datasets[0].id)
         self.assertEqual(ref, datasets[0])
 
+        locations = self.butler.registry.getDatasetLocations(ref)
+        self.assertEqual(locations[0], "FileDatastore@<butlerRoot>")
+
+        fake_ref = DatasetRef(
+            dataset_type,
+            dataId={"instrument": "DummyCamComp", "physical_filter": "d-r", "visit": 424},
+            id=uuid.uuid4(),
+            run="missing",
+        )
+        locations = self.butler.registry.getDatasetLocations(fake_ref)
+        self.assertEqual(locations, [])
+
         dataIds = list(self.butler.registry.queryDataIds("visit", dataId={"instrument": "DummyCamComp"}))
         self.assertEqual(len(dataIds), 2)