Ensure that dimension records are inserted in the right order

This makes sure that exposure is inserted before visit and
before visit_definition.

python/lsst/daf/butler/direct_butler.py

@@ -1890,8 +1890,9 @@ def transfer_dimension_records_from(
             source_butler, data_ids, elements
         )
 
-        for element, r in dimension_records.items():
-            records = [r[dataId] for dataId in r]
+        # Insert order is important.
+        for element in self.dimensions.sorted(dimension_records.keys()):
+            records = [r for r in dimension_records[element].values()]
             # Assume that if the record is already present that we can
             # use it without having to check that the record metadata
             # is consistent.
@@ -2097,8 +2098,9 @@ def transfer_from(
         with self.transaction():
             if dimension_records:
                 _LOG.verbose("Ensuring that dimension records exist for transferred datasets.")
-                for element, r in dimension_records.items():
-                    records = [r[dataId] for dataId in r]
+                # Order matters.
+                for element in self.dimensions.sorted(dimension_records.keys()):
+                    records = [r for r in dimension_records[element].values()]
                     # Assume that if the record is already present that we can
                     # use it without having to check that the record metadata
                     # is consistent.