Fail dataset type query early on non extant type

If a dataset type is used in queryDatasetTypes call, and it is a
type that is not known to the registry, the method should raise
instead of silently continuing. This was causing down stream
consumers of this method to get confusing registry issues.

python/lsst/daf/butler/registries/sql.py

@@ -80,6 +80,7 @@
     CollectionSearch,
 )
 from ..registry import queries
+
 from ..registry.wildcards import CategorizedWildcard, CollectionQuery, Ellipsis
 from ..registry.summaries import CollectionSummary
 from ..registry.managers import RegistryManagerTypes, RegistryManagerInstances
@@ -736,9 +737,16 @@ def queryDatasetTypes(self, expression: Any = ..., *, components: Optional[bool]
         done: Set[str] = set()
         for name in wildcard.strings:
             storage = self._managers.datasets.find(name)
-            if storage is not None:
-                done.add(storage.datasetType.name)
-                yield storage.datasetType
+            if storage is None:
+                raise ValueError(f"queryDatasetTypes was constrained with dataset type {name}, but no type"
+                                 "with that name has been declared to the registry. Please register the"
+                                 "dataset type and try again. Of note, if the registry is being used"
+                                 "in a parallel manner, it is possible the type has been registered "
+                                 "elsewhere, and the cache is out of date now, recreating the registry"
+                                 "instance, or calling the refresh method will update the registry to be"
+                                 "consistent with the other registry instances.")
+            done.add(storage.datasetType.name)
+            yield storage.datasetType
         if wildcard.patterns:
             # If components (the argument) is None, we'll save component
             # dataset that we might want to match, but only if their parents

python/lsst/daf/butler/registry/tests/_registry.py

@@ -66,6 +66,8 @@
     MissingCollectionError,
     OrphanedRecordError,
 )
+
+
 from ..interfaces import ButlerAttributeExistsError
 
 if TYPE_CHECKING:
@@ -2376,24 +2378,6 @@ def testQueryResultSummaries(self):
         # These queries yield no results due to various problems that can be
         # spotted prior to execution, yielding helpful diagnostics.
         for query, snippets in [
-            (
-                # Dataset type name doesn't match any existing dataset types.
-                registry.queryDatasets("nonexistent", collections=...),
-                ["nonexistent"],
-            ),
-            (
-                # Dataset type object isn't registered.
-                registry.queryDatasets(
-                    DatasetType(
-                        "nonexistent",
-                        dimensions=["instrument"],
-                        universe=registry.dimensions,
-                        storageClass="Image",
-                    ),
-                    collections=...
-                ),
-                ["nonexistent"],
-            ),
             (
                 # No datasets of this type in this collection.
                 registry.queryDatasets("flat", collections=["biases"]),