DM-13374: Deconstruct Butler prototype for redesign #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder how I missed those flake8 fixes. |
pschella
force-pushed
the
tickets/DM-13374
branch
from
d5444ae
to
79460a2
Compare
|
Probably because they were the result of some other changes on this ticket (I intend to squash all commits). |
timj
reviewed
Jan 29, 2018
| @@ -33,7 +32,7 @@ def _safeMakeMappingProxyType(data): | |||
| return MappingProxyType(data) | |||
|
|
|||
|
|
|||
| class DatasetType: | |||
| class DatasetType(object): | |||
There was a problem hiding this comment.
Is this needed? Python 3 doesn't need the explicit object inheritance.
timj
approved these changes
Jan 29, 2018
pschella
force-pushed
the
tickets/DM-13374
branch
from
79460a2
to
c318747
Compare
- Reset SqlRegistry to non-implemented and remove associated tests - Remove DataUnit subclass implementations - Rename DataUnitTypeSet -> DataUnitSet - Remove mentions of DataUnitMap - Merge DatasetLabel and DatasetHandle into DatasetRef - Rename type -> datasetType where appropriate - Don't assume anything about StorageClass in Registry - General style cleanup
pschella
force-pushed
the
tickets/DM-13374
branch
from
c318747
to
bba86ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.