DM-43845: Implement default data ID for RemoteButler #1003
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1003 +/- ##
=======================================
Coverage 89.04% 89.05%
=======================================
Files 347 347
Lines 44473 44507 +34
Branches 9146 9149 +3
=======================================
+ Hits 39601 39635 +34
Misses 3550 3550
Partials 1322 1322 ☔ View full report in Codecov by Sentry. |
dhirving
force-pushed
the
tickets/DM-43845
branch
from
f845667
to
0c446bc
Compare
Convert the exceptions used by expandDataId to ButlerUserError, so they can be propagated to the client side.
Like other non-required metadata fields in a dimension, region is allowed to be NULL in the database. That means that we also need to allow region to be NULL in serialized forms to be able to roundtrip dimension records through JSON.
Default data ID values are now passed to the server from RemoteButler, to augment data ID lookups in get() and find_dataset().
dhirving
force-pushed
the
tickets/DM-43845
branch
from
0c446bc
to
df8ee59
Compare
| class ExpandDataIdResponseModel(pydantic.BaseModel): | ||
| """Response model for expand_data_id.""" | ||
|
|
||
| data_coordinate: SerializedDataCoordinate |
There was a problem hiding this comment.
It's odd, but we never really use data_coordinate in this context. It would normally be called a data_id (and the docs call it expanded). I'm not asking you to change it, I'm commenting that we use data_id and "data coordinate" interchangeably but never use coordinate in variable names...
There was a problem hiding this comment.
There's a clearer distinction for the serialized ones than the unserialized ones... 'SerializedDataCoordinate' means "with dimension records" and 'SerializedDataId' means "no dimension records". It's a lot fuzzier in the business objects because a DataCoordinate could be either of those, and a DataId can be a DataCoordinate or a dict or something else.
Checklist
doc/changesconfigs/old_dimensions