Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43531: Implement queryDatasetTypes for RemoteButler #1006

Merged
merged 3 commits into from
May 1, 2024

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Apr 26, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 97.01493% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.06%. Comparing base (3ffd874) to head (2c19808).

Files Patch % Lines
.../lsst/daf/butler/remote_butler/_collection_args.py 90.90% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1006   +/-   ##
=======================================
  Coverage   89.05%   89.06%           
=======================================
  Files         347      347           
  Lines       44507    44553   +46     
  Branches     9149     9159   +10     
=======================================
+ Hits        39636    39680   +44     
- Misses       3550     3551    +1     
- Partials     1321     1322    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

To remove some unnecessary circular dependency, move private functions used only by RemoteButlerRegistry off of RemoteButler into RemoteButlerRegistry.
@dhirving dhirving force-pushed the tickets/DM-43531 branch 2 times, most recently from 45e1322 to ac6df02 Compare April 30, 2024 19:47
@dhirving dhirving marked this pull request as ready for review April 30, 2024 20:56
elif isinstance(item, str):
search.append(item)
else:
raise TypeError(f"Search patterns must be string or DatasetType, not {str(type(item))}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use lsst.utils.introspection.get_full_type_name(item) rather than str(type(item)). It handles our naming convention to filter out things with underscores.

@dhirving dhirving merged commit 63962e0 into main May 1, 2024
18 checks passed
@dhirving dhirving deleted the tickets/DM-43531 branch May 1, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants