Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-44109: Protect tests against httpx being available but no server deps #1007

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

timj
Copy link
Member

@timj timj commented Apr 29, 2024

776aaea changed the test assumptions. CernVMFS installations now do include httpx but do not include anything the server needs for testing.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

776aaea changed the test assumptions. CernVMFS installations now
do include httpx but do not include anything the server needs
for testing.
@timj timj requested a review from ktlim April 29, 2024 18:36
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (f490737) to head (9ecd191).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1007   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files         347      347           
  Lines       44507    44507           
  Branches     9149     9149           
=======================================
+ Hits        39635    39636    +1     
  Misses       3550     3550           
+ Partials     1322     1321    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj merged commit 75f9d25 into main Apr 29, 2024
18 checks passed
@timj timj deleted the tickets/DM-44109 branch April 29, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants