DM-43316: Clarify usage of Butler.collection_chains. #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A link to the interface makes it possible to actually use those methods, while a disclaimer about the duplication between it and Registry will minimize future compatibility problems.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
=======================================
Coverage 89.05% 89.05%
=======================================
Files 347 347
Lines 44507 44507
Branches 9149 9149
=======================================
Hits 39636 39636
Misses 3550 3550
Partials 1321 1321 ☔ View full report in Codecov by Sentry. |
dhirving
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fleshes out the documentation of the
Butler.collection_chainsproperty to make it clearer to non-Middleware developers.Checklist
doc/changesconfigs/old_dimensions