DM-44147: Allow alternate dimensions in file template #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
=======================================
Coverage 89.06% 89.06%
=======================================
Files 347 347
Lines 44553 44574 +21
Branches 9159 9164 +5
=======================================
+ Hits 39680 39701 +21
Misses 3551 3551
Partials 1322 1322 ☔ View full report in Codecov by Sentry. |
timj
commented
May 1, 2024
TallJimbo
approved these changes
May 1, 2024
This is mainly to allow day_obs/group to be used directly in
templates with newer dimension universes whilst also supporting
older universes.
Now you can say '{exposure|group}' and only use group in the
template if there is no exposure in the dataId. Similarly for
day_obs you can say '{day_obs|visit.day_obs|exposure.day_obs}'
and pick the first relevant one. The alternates can be removed
when we are sure no older universe registries exist.
{exposure.obs_id}_{group} -> {exposure.obs_id|group}
{visit.day_obs}/{exposure.day_obs} -> {day_obs|visit.day_obs|exposure.day_obs}
This required a minor reorganization since TypedDict mandates literal string fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesconfigs/old_dimensions