Implement delayed instantiation of StorageClass (DM-15887) #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DatasetType handling of storageClass property was re-implemented to allow instance construction from StorageClass name. In that case `storageClass` property uses delayed instantiation (which should only be done when butler is properly configured). This allows DatasetType use in a context when butler is not initialised and only name of the StorageClass is provided (e.g. in Pipeline construction). Comparison and hash methods of DatasetType class have to be re-implemented because internal state became more complicated.
timj
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatasetType handling of storageClass property was re-implemented to
allow instance construction from StorageClass name. In that case
storageClassproperty uses delayed instantiation (which should only bedone when butler is properly configured). This allows DatasetType use in
a context when butler is not initialised and only name of the
StorageClass is provided (e.g. in Pipeline construction).
Comparison and hash methods of DatasetType class have to be re-implemented
because internal state became more complicated.