DM-16867: Move expr_parser from pipe_supertask to daf_butler #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also imported a copy of PLY package as a sub-package, for testing only now, can make it eups package later if we want to use PLY.
Unit test for grammar was added too. Temporarily removed some keywords from lexer to suppress warnings from parser.
Data units were renamed in daf_butler schema, Camera becomes Instrument and Sensor becomes Detector. These names are used in few places in this package too, follow that renaming in all usage of the unit names.
TallJimbo
approved these changes
Jan 4, 2019
andy-slac
force-pushed
the
tickets/DM-16867
branch
from
f917f3a
to
4ff1af2
Compare
|
@TallJimbo, there is a small change since your approval - |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More or less complete history was copied too, branch
tickets/DM-16867-supertask-historycontains that history and its HEAD corresponds to the master ofpipe_supertask. All migration changes to the code were done after merging that branch intotickets/DM-16867.