DM-17611: performance optimizations for data ID manipulations #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callers of toNameSet didn't actually care that they got a DimensionNameSet back; they just wanted something with .names, and frequently the object they passed in would have already qualified. In that case, we now just return that object directly, and toNameSet has been renamed to conformSet to reflect that new behavior.
Doing this repeatedly for every data ID with a certain set of keys was wasting a lot of time.
This separates operation unique to DimensionGraph construction and make those a bit easier to follow and control. This will be useful for later commits that try to limit the time spent in DimensionGraph construction via caching.
We only need the per-DatasetType data IDs expanded, because no one ever looks at the extra metadata associated with the row-wide one. In the future we should investigate whether we can get rid of the row-wide data ID entirely, but it does currently appear to be used in pipe.base.GraphBuilder.
|
This change was reviewed on DM-17496; I'm just moving it here to separate it from unrelated ongoing work on that ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.