Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-14459: Check for file overwrite #133

Merged
merged 5 commits into from Feb 19, 2019
Merged

DM-14459: Check for file overwrite #133

merged 5 commits into from Feb 19, 2019

Conversation

timj
Copy link
Member

@timj timj commented Feb 18, 2019

No description provided.

@timj timj requested a review from TallJimbo February 18, 2019 21:58
Read-only; update via `Registry.addDataset()`,
`QuantumGraph.addDataset()`, or `Butler.put()`.
Read-only; update via `~lsst.daf.butler.Registry.addDataset()`,
`Quantum.addPredictedInput()`, or `lsst.daf.butler.Butler.put()`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I'm seeing your Slack question in context, I think this should be Quantum.addOutput instead.

* Provide method to get root name and component name.

Without this when datasetTypeName=a.b and the template includes
{datasetType}.{component} the result before this change was
"a.b.b". After this change it is correctly "a.b".
This is more readable than the class name.
@timj timj merged commit de9774b into master Feb 19, 2019
@timj timj deleted the tickets/DM-14459 branch February 19, 2019 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants