DM-18438: Add ability to specify field lengths for DatabaseDict and use that #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PosixDatastore now defines the lengths for PosixDatastoreRecords
|
@natelust I decided to pass in a separate dict with the lengths. I could change it so that the length could be passed in through the types = {"path": (str, 256), "formatter": (str, 128), "storage_class": (str, 64),
"file_size": int, "checksum": (str, 64), "dataset_id": int} |
natelust
approved these changes
Mar 18, 2019
tests/test_sqlDatabaseDict.py
Outdated
| value = namedtuple("TestValue", ["y", "z"]) | ||
| data = { | ||
| 0: value(y="zero", z=0.0), | ||
| 1: value(y="this is too long", z=0.1), |
There was a problem hiding this comment.
My only comment is that it might be nice to name these keys "passing" and "failing" or something like that rather than generic 0 and 1 magic numbers, but its in test code, and I dont feel very strongly about it.
sqlite ignores varchar length. An explicit check constraint is required to force a length check. This commit adds that and a corresponding test to ensure that the lengths have been applied properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PosixDatastore now defines the lengths for PosixDatastoreRecords