Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-15374: Add Permissions/Constraints support code #144

Merged
merged 13 commits into from Apr 15, 2019
Merged

DM-15374: Add Permissions/Constraints support code #144

merged 13 commits into from Apr 15, 2019

Conversation

timj
Copy link
Member

@timj timj commented Apr 4, 2019

No description provided.

@timj timj force-pushed the tickets/DM-15374 branch 2 times, most recently from 42aed63 to 51be499 Compare April 5, 2019 18:54
@timj timj marked this pull request as ready for review April 5, 2019 20:48
@timj timj requested a review from TallJimbo April 5, 2019 20:48
TallJimbo
TallJimbo approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only very minor comments on the PR.

My only big one is that I'm still a little uncomfortable with the "permissions" terminology, and wouldn't mind throwing this problem to #dm-naming-things to see if we can get any better ideas.

python/lsst/daf/butler/core/configSupport.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/core/configSupport.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/core/permissions.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/core/permissions.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/core/permissions.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/core/permissions.py Outdated Show resolved Hide resolved
tests/test_permissions.py Outdated Show resolved Hide resolved
tests/test_permissions.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/datastores/chainedDatastore.py Outdated Show resolved Hide resolved
tests/test_datastore.py Outdated Show resolved Hide resolved
@timj timj changed the title DM-15374: Add Permissions support code DM-15374: Add Permissions/Constraints support code Apr 15, 2019
@timj
Add constraints checking to datastore.ingest
c42249c 
Without this ingest was bypassing the constraints.
@timj timj merged commit 7939090 into master Apr 15, 2019
@timj timj deleted the tickets/DM-15374 branch April 15, 2019 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @TallJimbo