Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/DM-19387 vectorize adding dimension entries in registry #146

Merged
merged 3 commits into from Apr 30, 2019
Merged

Tickets/DM-19387 vectorize adding dimension entries in registry #146

merged 3 commits into from Apr 30, 2019

Conversation

natelust
Copy link
Contributor

No description provided.

czwa
czwa approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we discussed these issues in person and came to the conclusion that a future full-vectorization will solve any major concerns I had.

@natelust
Introduce sqlalchemy type for registry
3b4b8db 
Add an sqlalchemy type to handle regions so that they will
automatically be base64 encoded and decoded when writing or reading
from the registry.
@natelust natelust merged commit 904b8f9 into master Apr 30, 2019
@timj timj deleted the tickets/DM-19387 branch April 22, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj left review comments

@czwa czwa czwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@natelust @timj @czwa