DM-19583: Config file includes #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timj
commented
May 2, 2019
timj
commented
- Add support for explicitly importing other configs into the hierarchy.
- Add dumpButlerConfig command to allow a config to be checked.
This runs after resolving all the overrides.
Allows a configuration to explicitly read another configuration that will be merged with subsequent values in the original YAML.
timj
force-pushed
the
tickets/DM-19583
branch
2 times, most recently
from
4c4c2d7
to
5211002
Compare
Forwarded directly to ButlerConfig constructor.
natelust
approved these changes
May 3, 2019
| * The supplied config is read in. | ||
| * If any leaf nodes in the configuration end in ``configIncludes`` they values (either a scalar or list) will be treated as the names of other config files. | ||
| These files will be located either as an absolute path or relative to the current working directory, or the directory in which the original configuration file was found. | ||
| The contents of these files will then be inserted into the configuration at the same hierarchy as the ``configIncludes`` directive, with priority given to the values defined explicitly in the parent configuration (for lists of include files later files overwrite content from earlier ones). |
There was a problem hiding this comment.
fix "lists of include files later files"
There was a problem hiding this comment.
Fix in what way? I can add a comma after files?
python/lsst/daf/butler/butler.py
Outdated
| Note that when ``standalone=False`` (the default), the configuration | ||
| search path (see `ConfigSubset.defaultSearchPaths`) that was used to | ||
| construct the repository should also be used to construct any Butlers | ||
| to it to avoid configuration inconsistencies. |
There was a problem hiding this comment.
I think this is a very dangerous way to handle things and should be re thought in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.