DM-19671: Allow setConfigRoot to retain input values #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust setConfigRoot such that it will optionally not override values in the supplied config. This is the common use case from makeRepo where an external config would like to set a value for root, but that value was always being overridden. Update makeRepo to disable overwrite.
The repository is created but the configuration for it is written elsewhere.
andy-slac
approved these changes
May 8, 2019
...since sometimes you can now ask not to override even if you are updating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust setConfigRoot such that it will optionally not override values in the supplied config. This is the common use case from makeRepo where an external config would like to set a value for root, but that value was always being overridden.
Update makeRepo to disable overwrite.