DM-13600: Add YAML formatter #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Feb 21, 2018
| Object to coerce to expected type. | ||
| storageClass : `StorageClass` | ||
| StorageClass associated with `inMemoryDataset`. | ||
| pytype : `class`, optional |
There was a problem hiding this comment.
Ok. I'm a bit unclear as to what we really want there so I'll switch it.
| ------- | ||
| data : `object` | ||
| Either data as Python object read from YAML file, or None | ||
| if the file could not be opened. |
There was a problem hiding this comment.
I'm a bit surprised that we don't raise an exception when we can't find the file. Is this the pattern for all formatters?
There was a problem hiding this comment.
It made FileFormatter.read() a little less convoluted and finding the file was the only thing that mattered. I think this code will have to be rejiggered when we start using templates for file names so I'll have another look at that time. @pschella didn't like including the component name in the filename (I think he preferred it to be under the control of the template) so this will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic YAML formatter and update test config and tests to ensure that YAML, JSON and Pickle are tested.