Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-18739: Make gen3.py skip defects #166

Merged
merged 1 commit into from Jun 21, 2019
Merged

DM-18739: Make gen3.py skip defects #166

merged 1 commit into from Jun 21, 2019

Conversation

SimonKrughoff
Copy link
Contributor

No description provided.

@SimonKrughoff SimonKrughoff requested a review from r-owen May 30, 2019 16:50
r-owen
r-owen approved these changes May 30, 2019
View reviewed changes
Copy link

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (I think; I'm not really familiar with the reasoning behind not converting these files)

@timj
Copy link
Member

timj commented May 30, 2019

I think because in gen2 to gen3 conversion @SimonKrughoff is suggesting that we recreate the defects from scratch rather than migrating them from gen2 repo.

@SimonKrughoff
Copy link
Contributor Author

That's exactly right.

@SimonKrughoff SimonKrughoff merged commit 94c55ef into master Jun 21, 2019
@timj timj deleted the tickets/DM-18739 branch April 22, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-owen r-owen r-owen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SimonKrughoff @timj @r-owen