DM-20763: Add initial support for Gen3 Butler to obs_decam #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-20763
branch
3 times, most recently
from
53b9e95
to
3aca04c
Compare
timj
approved these changes
Aug 15, 2019
parejkoj
force-pushed
the
tickets/DM-20763
branch
2 times, most recently
from
611e9f7
to
1174646
Compare
While implementing the DarkEnergyCamera Instrument: * applyConfigOverrides() had an obvious default implementation using a list of paths. * getCamera() was lifted from obs_subaru as an abstractmethod. We will eventually have versioned Camera repositories, but until then we need a way to access Camera information for an Instrument. Add instrument_test framework for obs package tests.
Instrument will be moved into obs_base eventually, and we can just use obs.base.FilterDefintions then.
TallJimbo
force-pushed
the
tickets/DM-20763
branch
from
1174646
to
f616843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.