-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-20842: Change Formatter API #176
Merged
Merged
Commits on Jul 31, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e793742 - Browse repository at this point
Copy the full SHA e793742View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4fa42a - Browse repository at this point
Copy the full SHA c4fa42aView commit details -
Change Formatter to require a FileDescriptor contructor argument
The motivation for this is to simplify formatters so that they know they can store state in their instance without fear that a Datastore is going to reuse the Formatter for some other location. * This changes the read() and write() methods since they no longer need FileDescriptor parameter. * All the formatters need to be tweaked. * Datastore needs changing to ensure that FileDescriptor is created a bit earlier. * getFormatter gets an extra argument which can be None for formatters that will not be using read/write at all.
Configuration menu - View commit details
-
Copy full SHA for adc03b8 - Browse repository at this point
Copy the full SHA adc03b8View commit details
Commits on Aug 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6ffe5e3 - Browse repository at this point
Copy the full SHA 6ffe5e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04b02cc - Browse repository at this point
Copy the full SHA 04b02ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff913a0 - Browse repository at this point
Copy the full SHA ff913a0View commit details -
Reimplement factory to allow a class to be returned
Instance retrieval is now layered on top of class retrieval.
Configuration menu - View commit details
-
Copy full SHA for 6d4f3d1 - Browse repository at this point
Copy the full SHA 6d4f3d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc71985 - Browse repository at this point
Copy the full SHA dc71985View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d7b6f1 - Browse repository at this point
Copy the full SHA 6d7b6f1View commit details -
Add Formatter.predictPathWithLocation method
This can be a class method and so be distinct from the instance methoer predictPath
Configuration menu - View commit details
-
Copy full SHA for bfdbba4 - Browse repository at this point
Copy the full SHA bfdbba4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22fe2e3 - Browse repository at this point
Copy the full SHA 22fe2e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f13db77 - Browse repository at this point
Copy the full SHA f13db77View commit details
Commits on Aug 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for cd66797 - Browse repository at this point
Copy the full SHA cd66797View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.