Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-20842: Change Formatter API #176

Merged
merged 13 commits into from
Aug 5, 2019
Merged

DM-20842: Change Formatter API #176

merged 13 commits into from
Aug 5, 2019

Commits on Jul 31, 2019

  1. Configuration menu
    Copy the full SHA
    e793742 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4fa42a View commit details
    Browse the repository at this point in the history
  3. Change Formatter to require a FileDescriptor contructor argument

    The motivation for this is to simplify formatters so
    that they know they can store state in their instance
    without fear that a Datastore is going to reuse the
    Formatter for some other location.
    
    * This changes the read() and write() methods since they no
      longer need FileDescriptor parameter.
    * All the formatters need to be tweaked.
    * Datastore needs changing to ensure that FileDescriptor is
      created a bit earlier.
    * getFormatter gets an extra argument which can be None for
      formatters that will not be using read/write at all.
    timj committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    adc03b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. Configuration menu
    Copy the full SHA
    6ffe5e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    04b02cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ff913a0 View commit details
    Browse the repository at this point in the history
  4. Reimplement factory to allow a class to be returned

    Instance retrieval is now layered on top of class retrieval.
    timj committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    6d4f3d1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dc71985 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6d7b6f1 View commit details
    Browse the repository at this point in the history
  7. Add Formatter.predictPathWithLocation method

    This can be a class method and so be distinct from the instance
    methoer predictPath
    timj committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    bfdbba4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    22fe2e3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f13db77 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2019

  1. Fix some docstrings

    timj committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    cd66797 View commit details
    Browse the repository at this point in the history