Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-20915: Add str(Formatter) and force Formatter to require an arg for constructor #178

Merged
merged 8 commits into from
Aug 6, 2019

Commits on Aug 5, 2019

  1. Require a Formatter takes a parameter

    Update tests to match, switching some of them to using
    getFormatterClass so that the parameter is irrelevant.
    timj committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    ab9394c View commit details
    Browse the repository at this point in the history
  2. Add str(Formatter)

    timj committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    bec1e7a View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Configuration menu
    Copy the full SHA
    e60bda2 View commit details
    Browse the repository at this point in the history
  2. Change how getFullTypeName works with builtins

    Having it return "builtins.str" serves no useful purpose
    and it's much easier to return "str" and "dict".
    timj committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    c88b9f8 View commit details
    Browse the repository at this point in the history
  3. Change StorageClass constructor so that it extracts name early

    Previously the python type to name conversion was deferred until
    the python type was needed.  This is unnecessary and causes
    problems with repr() implementations. Now always extract the full
    name using getFullTypeName.
    timj committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    ad65175 View commit details
    Browse the repository at this point in the history
  4. Rewrite StorageClass.__repr__

    Make it more compact by removing entities that are defaulted.
    timj committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    b173a3e View commit details
    Browse the repository at this point in the history
  5. Add Formatter.__repr__

    timj committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    e6abc75 View commit details
    Browse the repository at this point in the history
  6. Update Instrument.getRawFormatter docstring

    Now consistent in mentioning it returns a Formatter class not
    Formatter instance.
    timj committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    7ce1a64 View commit details
    Browse the repository at this point in the history