DM-20205 Add ability to defer loading datasets #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
approved these changes
Aug 16, 2019
|
|
||
| @dataclasses.dataclass(frozen=True) | ||
| class DeferredDatasetHandle: | ||
| """Class to support deferred loading of a dataset from a butler |
There was a problem hiding this comment.
Sentences should end with dot.
| typically used to efficiently read only a subset of the dataset. | ||
| kwds : `dict` | ||
| Additional keyword arguments used to augment or construct a | ||
| `DataId`. See `DataId` parameters. |
There was a problem hiding this comment.
No in this case I do mean a DataId object itself
| else: | ||
| mergedParameters = {} | ||
|
|
||
| return self._get(parameters) |
There was a problem hiding this comment.
Do you want to pass mergedParameters here?
| parameters : `dict` or None | ||
| parameters passed to the butler get method. Defaults to None. | ||
| If not None, this dict will be merged with the parameters dict | ||
| used to construct the `DeferredDatasetHandle` class |
There was a problem hiding this comment.
Sentences should start with capital letter and end with dot.
python/lsst/daf/butler/butler.py
Outdated
| def getDeferred(self, datasetRefOrType: typing.Union[DatasetRef, DatasetType, str], | ||
| dataId: typing.Union[dict, DataId] = None, parameters: typing.Union[dict, None] = None, | ||
| **kwds) -> dDH.DeferredDatasetHandle: | ||
|
|
natelust
force-pushed
the
tickets/DM-20205
branch
2 times, most recently
from
45fb698
to
16cb489
Compare
Add the ability for the butler to return a handle to a dataset such that actual loading of the dataset can occur at a later time.
TallJimbo
force-pushed
the
tickets/DM-20205
branch
from
16cb489
to
03b8715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability for the butler to return a handle to a dataset
such that actual loading of the dataset can occur at a later time.