DM 21015: Fix AWS mock credentials. #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Aug 20, 2019
There was a problem hiding this comment.
I have two main comments:
- It looks to me like this entire test case is mocked out so why all the work to pass through real credentials?
- If we are trying to pass through real credentials then there is too much duplicated code here that should be moved to a single location: s3utils seems plausible.
DinoBektesevic
force-pushed
the
tickets/DM-21015
branch
from
3a344d1
to
e443ddc
Compare
timj
reviewed
Aug 20, 2019
DinoBektesevic
force-pushed
the
tickets/DM-21015
branch
from
e443ddc
to
1d0939d
Compare
timj
approved these changes
Aug 20, 2019
DinoBektesevic
force-pushed
the
tickets/DM-21015
branch
from
aa54f1b
to
8dd580b
Compare
…ck in test_butler.
DinoBektesevic
force-pushed
the
tickets/DM-21015
branch
from
8dd580b
to
49ed6bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run the S3 datastore tests, with
boto3andmotoinstalled, they fail unless some values are present in a~/.aws/credentialsfile.Tests now check whether the file or if the environmental variables are set and if not sets them. The values are unset at the end of the tests.