DM-21222: Stop forcing existence of credentials in connection strings. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoBektesevic
changed the title
timj
reviewed
Sep 9, 2019
|
I was just thinking of removing most of the error Reading through the file twice (for |
Instead of parsing through the file twice with `exists` and then `getAuth` re-write the `DbAuth.getAuth` method to allow username and password to be None. This requires silencing any errors when credentials are miss-configured from ConnectionStringFactory's side. Short of having an explicit key in config stating whether a credentials lookup is desired there is no clear cut way to say if we must insist that username/password must exist or not. Instead, we believe the provided db string and try to return it unchanged as often as possible unless everything is configured correctly.
|
Ok. redid it the way @ktlim wanted. Username and password are allowed to be |
brianv0
approved these changes
Sep 10, 2019
|
@ktlim You are probably quite busy this week, but could you take a look and comment on the changes. Is this more like what you had in mind? Someone should also run Jenkins on this because I don't have the privileges too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not forcing username and password in connection strings allows other mechanisms, such as Oracle Wallet, to insert the credentials.
It was difficult to untangle
getAuthinto sub-functionality soexistsis implemented in terms ofgetAuth. Is that ok?Would this work?